Fix horizontal scrollbar disappearing when rows removed #321
+88
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires another workaround for AvaloniaUI/Avalonia#15075 as the header presenter needs a height of 0 in the tests.
When items are removed, the horizontal scrollbar is reset even if the column headers do not fit in the viewport.
Fixes horizontal scrollbar disappearing when all rows removed.
|
Tested and LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a horizontal scrollbar was needed to show all columns but there were no rows then no horizontal scrollbar was shown.
Fix this by getting the desired width for the
TreeDataGridRowsPresenterfrom the columns if there are no rows.Had to also update the test templates to include a column scroll viewer. Because the existing tests expect the column header to be of 0 height, needed to work around AvaloniaUI/Avalonia#15075 in
TreeDataGridPresenterBase.